[Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

[Victor Toso]

Hi,

On Thu, Jul 27, 2017 at 12:39:32PM +0200, Christophe Fergeau wrote:
> On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote:
> > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote:
> > > Not really familiar with GitLab merge requests but on GitHub they
> > > remain open till closed so this would help with old ones.
> > > The big change on moving to full PR is the way of commenting patches.
> > > Unless PR are just used for tracking and are replicated to ML but
> > > maybe is hard to keep them consistent. I think is possible to configure
> > > PRs to send changes to ML. This would make the history persistent on
> > > the ML.
> > >
> > > Could we try for a period and see how does it go?
> >
> > +1, but how should we approach that? I think we need to move from
> > freedesktop to either gitlab or github first otherwise we can get
> > confused on what's going on.
> >
>
> Just to be sure, you are both suggesting switching to pull requests,
> and doing the reviews in gitlab web UI?

My suggestion was (1) move to gitlab and (2) play with MR (side by
side with sending the patch series to mailing list, for instance...)

But if a reviewed only review on mailing list, it might come to the
situation where the reviewer does not look into the web ui and the
problem that started this thread ends up not being solved at all, right?

> The initial problem is that some reviews are not done in a timely
> manner. Being able to easily get a list of pending reviews was brought
> forward as a potential solution to this problem, and apparently, you
> both think that switching from email based reviews to a web based review
> system would help in getting more reviews faster? (iow, it would make
> you more efficient at reviewing code, and you vastly prefer that over
> email).

My preferred way to review is to apply patches and git diff with
vimdiff. That might change with MR, I don't know.

Between web ui/mail for code review, the difference shouldn't be too big
for me. I see the diff in one place and I reply with comments somewhere
else (mail/web ui). The difference might be in applying patches as I do
have some scripts that work well with mutt...

> I'm not necessarily opposed to trying things out, I'm just trying to get
> a clear view of what we are expecting to get out of the change.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170727/d170c81b/attachment.sig>