[Spice-devel] [PATCH spice-gtk v6 1/4] Add check for macOS and macOS specific define to allow ucontext

[Frediano Ziglio]

> 
> 
> > On 31 May 2017, at 16:12, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > 
> > On Wed, May 31, 2017 at 02:46:51PM +0200, Christophe de Dinechin wrote:
> >> From: Christophe de Dinechin <dinechin at redhat.com>
> >> 
> >> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> >> ---
> >> configure.ac | 15 +++++++++++++++
> >> 1 file changed, 15 insertions(+)
> >> 
> >> diff --git a/configure.ac b/configure.ac
> >> index ff00d73..62acafc 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -62,6 +62,18 @@ esac
> >> AC_MSG_RESULT([$os_win32])
> >> AM_CONDITIONAL([OS_WIN32],[test "$os_win32" = "yes"])
> >> 
> >> +AC_MSG_CHECKING([for native macOS])
> >> +case "$host_os" in
> >> +     *darwin*)
> >> +        os_mac=yes
> >> +        ;;
> >> +     *)
> >> +        os_mac=no
> >> +        ;;
> >> +esac
> >> +AC_MSG_RESULT([$os_mac])
> > 
> > 
> >> +AM_CONDITIONAL([OS_MAC],[test "$os_mac" = "yes"])
> > 
> > Is this OS_MAC useful at all?
> 
> It was useful initially before I added HAVE_EGL. And I think it will be
> useful soon for Mac audio. I think it is cleaner to define it at the time we
> add the mac in automake, because it keeps the Mac and Windows code more
> similar.
> 
> > 
> > Christophe

It's just question of style (not having an unused conditional/more coherent
with Windows).
Personally I slightly prefer keeping the conditional even if not used.

Frediano