[Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

[Christophe Fergeau]

On Thu, Jun 08, 2017 at 04:31:20AM -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > On Thu, Jun 08, 2017 at 12:55:38AM +0400, marcandre.lureau at redhat.com wrote:
> > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > 
> > > Use shorter line, use the common "d" variable for private data access,
> > > add brackets to ease reading the inner block vs the condition, remove
> > > needless != NULL.
> > 
> > I'd lean towards NACK for this one, one letter variable names is imo
> > very bad for readability. I know this is widespread in the spice-gtk
> > codebase, but I'd at least rather not expand that usage.
> > 
> 
> You may rename it "priv", but then you lost the benefit of being really short.

Being really short is a benefit? This is where we are going to disagree :)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170608/81b8c7cf/attachment-0001.sig>