[Spice-devel] [PATCH qxl-wddm-dod v2] ci: Integrate with Appveyor

Frediano Ziglio fziglio at redhat.com
Thu Jun 8 10:42:58 UTC 2017


> Hello All,

> This patch introduces Appveyor CI configuration file.

> Having this patch pushed and qxl-wddm-dod repository registered at Appveyor,
> every push or merge request will be automatically built on their servers.

If you need to comment a single patch to add explanation maybe this additional 
explanation should be added to the commit message. 

> Build status notifications will be sent to this list (
> spice-devel at lists.freedesktop.org )

It seems that the message arrive as html with no corresponding test, see 
https://lists.freedesktop.org/archives/spice-devel/2017-June/037963.html. 
Is possible to have pure text messages instead? 

> Best Regards,
> Dmitry

> > On 8 Jun 2017, at 10:10 AM, Dmitry Fleytman < dmitry at daynix.com > wrote:
> 

> > Signed-off-by: Dmitry Fleytman < dmitry at daynix.com >
> 
> > ---
> 
> > .appveyor.yml | 18 ++++++++++++++++++
> 
> > 1 file changed, 18 insertions(+)
> 
> > create mode 100644 .appveyor.yml
> 

> > diff --git a/.appveyor.yml b/.appveyor.yml
> 
> > new file mode 100644
> 
> > index 0000000..f3f3e5c
> 
> > --- /dev/null
> 
> > +++ b/.appveyor.yml
> 
> > @@ -0,0 +1,18 @@
> 
> > +image: Visual Studio 2015
> 
> > +
> 

This cause to stick to a version of images and if image are going to be removed in the 
future this won't work. I use AppVeyor for another project and I know images are 
updated and obsolete ones are removed after a while. From my experience is better to 
fix the issues with the last machine version. 

> > +version: build-{build}-{branch}
> 
> > +
> 
> > +before_build:
> 
> > + - ren "C:\Program Files (x86)\Windows Kits\10\include\00wdf" "wdf"
> 
> > +
> 
> > +build_script: buildAll.bat
> 
> > +
> 
> > +skip_commits:
> 
> > + message: /\[ci skip\]/
> 
> > +
> 

what does this? 

> > +notifications:
> 
> > + - provider: Email
> 
> > + to: spice-devel at lists.freedesktop.org
> 

Not strictly related to this patch, is usually a good idea to add sender e-mail 
to the ML. Did you do it? 

> > + on_build_success: false
> 
> > + on_build_failure: true
> 
> > + on_build_status_changed: true
> 

Frediano 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170608/d95cb331/attachment-0001.html>


More information about the Spice-devel mailing list