[Spice-devel] [PATCH spice-gtk v3 1/6] display-gst: check codec type before creating decoder

Christophe Fergeau cfergeau at redhat.com
Thu Jun 8 14:03:21 UTC 2017


On Thu, Jun 08, 2017 at 03:55:11PM +0200, Victor Toso wrote:
> > 
> > Not really worth all that discussion, your patch is ok :)
> 
> Ah, I liked the discusison mostly because this would be a spice <->
> spice-gtk communication bug and I'm not sure either if we should go for
> CRITICAL or WARNING messages in such cases.
> 
> I mean, in the past, for spice server, there was discussion about when
> to assert(). The result was that only when it would be a bug inside the
> component (never on client's input/configuration for instance)
> 
> Anyway, thanks for the discussion :)

To tie this in with the logging discussion, you can read the latest
comment from ebassi in this blog post about g_log_structured ;)

https://blog.gtk.org/2017/05/04/logging-and-more/

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170608/20dbdaab/attachment.sig>


More information about the Spice-devel mailing list