[Spice-devel] [PATCH] Use space and not colon to separate log domains

[Jonathon Jongsma]

I was actually about to send this exact patch ;)

Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Thu, 2017-06-08 at 18:22 +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> According to https://developer.gnome.org/glib/stable/glib-running.htm
> l,
> G_MESSAGES_DEBUG is a space-separated list of log domains for which
> informational and debug messages should be printed
> 
> Note that the equivalent code in spice-util.c gets it right.
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  common/log.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/log.c b/common/log.c
> index 7437d3e..0ffaf0f 100644
> --- a/common/log.c
> +++ b/common/log.c
> @@ -85,7 +85,7 @@ static void spice_log_set_debug_level(void)
>              if (debug_env == NULL) {
>                  g_setenv("G_MESSAGES_DEBUG", SPICE_LOG_DOMAIN,
> FALSE);
>              } else {
> -                debug_env = g_strconcat(debug_env, ":",
> SPICE_LOG_DOMAIN, NULL);
> +                debug_env = g_strconcat(debug_env, " ",
> SPICE_LOG_DOMAIN, NULL);
>                  g_setenv("G_MESSAGES_DEBUG", SPICE_LOG_DOMAIN,
> FALSE);
>                  g_free(debug_env);
>              }