[Spice-devel] [PATCH spice-gtk v3 1/6] display-gst: check codec type before creating decoder

[Victor Toso]

Hi,

On Fri, Jun 09, 2017 at 05:36:30PM +0200, Christophe de Dinechin wrote:
> 
> > On 8 Jun 2017, at 16:47, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > 
> > On Thu, Jun 08, 2017 at 10:39:53AM -0400, Frediano Ziglio wrote:
> >>> 
> >>> On Thu, Jun 08, 2017 at 03:55:11PM +0200, Victor Toso wrote:
> >>>>> 
> >>>>> Not really worth all that discussion, your patch is ok :)
> >>>> 
> >>>> Ah, I liked the discusison mostly because this would be a spice <->
> >>>> spice-gtk communication bug and I'm not sure either if we should go for
> >>>> CRITICAL or WARNING messages in such cases.
> >>>> 
> >>>> I mean, in the past, for spice server, there was discussion about when
> >>>> to assert(). The result was that only when it would be a bug inside the
> >>>> component (never on client's input/configuration for instance)
> >>>> 
> >>>> Anyway, thanks for the discussion :)
> >>> 
> >>> To tie this in with the logging discussion, you can read the latest
> >>> comment from ebassi in this blog post about g_log_structured ;)
> >>> 
> >>> https://blog.gtk.org/2017/05/04/logging-and-more/
> >>> 
> >>> Christophe
> >>> 
> >> 
> >> Wrong thread? Looks like the structured logging would be more
> >> appropriate in Chistophe D thread.
> > 
> > Nope, the comment I refer to
> > 
> > «  Warnings (and criticals) are meant to be used for programmer error
> > and internal state consistency checks — and the expectation is that
> > anything that follows a warning is undefined behaviour. Personally, I
> > prefer asserting much more than just warning, because that catches real
> > programmer errors, but warnings usually have more understandable
> > messages. »
> 
> I see a fair number of warnings when starting spicy, notably a number of assertions.
> 
> (spicy:3327): GSpice-CRITICAL **: display_handle_stream_data: assertion 'st != NULL' failed
> (spicy:3327): GSpice-CRITICAL **: display_handle_stream_data: assertion 'st != NULL' failed
> 
> Many such messages, making log output hard to read (even on the traces
> branch), but not annoying enough that we fix them. Better than a
> crash, though.

I only see those while moving code around and doing tests.
If you see this all the time, please file a bug about it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170609/3cd86d73/attachment.sig>