[Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

[Christophe Fergeau]

On Tue, Jun 13, 2017 at 03:59:06AM -0400, Frediano Ziglio wrote:
> I have strange feelings about this series.
> 
> First you removed most of logging test and change the entirely logging.
> This is for me an enough reason for a nack. Usually the test define
> the behaviour of the API (in this case logging) and the fact you have
> to change a lot means that the new one is not compatible. Considering
> that this API is used by other projects and is not compatible seems
> to indicate that other projects are now broken. There are other
> possibilities like the test was too strict but there are no much
> comments on this.
> 
> About compatibility as Christophe F said you entirely wiped out
> the current environment settings which is one of the reason of
> code mess.

Most of the test cases were also there to check the interactions between
g_log and spice_log, and the corresponding environment variables. If you
rip spice_log out, then the test cases would become "let's unit test the
GLog API", which does not make sense to have in spice-common.

As I said before, it's probably possible to keep some degraded
SPICE_DEBUG_LEVEL/SPICE_ABORT_LEVEL functionality (ie just what maps
easily to glib) while removing most of this code, so we can probably
have this discussion.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170613/c9ce2cf2/attachment.sig>