[Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

[Victor Toso]

Hi,

On Tue, Jun 13, 2017 at 04:42:27AM -0400, Marc-André Lureau wrote:
> Hi
>
> ----- Original Message -----
> > On Tue, Jun 13, 2017 at 09:45:20AM +0200, Christophe de Dinechin wrote:
> > > > 5. The spice_log_init deals with hard-coded variables in a
> > > > hard-coded way. I purposely had a function taking a string, and
> > > > called either with env vars or command line options. I was thinking
> > > > long-term about other inputs, notably the client being able to send
> > > > debug options to the server.
> > > >
> > > > Whoo, client sending debug options to the server? That is quite strange.
> > >
> > > What I would like is to be able to enable collection of debug
> > > information (ideally on a per-session basis) without having to restart
> > > the server. Is that strange?
>
> "enabling a collection of debug information" at run-time could be done
> through a server API, exposed as a QMP command (or other interface for
> other servers). I don't think the client & SPICE protocol should have
> this admin/debug feature.

Although it might be useful, I agree that this could bring unexpected
problems? Unless this message is for development purpose only and it
would be disabled in production (disable a caps for instance)

> > Let's first see if we manage to add useful debug logs to both the client
> > and the server, then we can look into adding this :) In the mean time,
> > this will probably be possible to do through a gdb script.

Yeah. I too think we should focus in one thing at the time otherwise
it'll be hard to follow ideas, comments, proposals. At very least a OT
tag to make it clear that is not fully related to the thread/review.

    toso
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170613/8ab6a35b/attachment.sig>