[Spice-devel] [PATCH spice-common 1/4] log: replace spice log with glib

[Frediano Ziglio]

> 
> Hi,
> 
> On Mon, Jun 12, 2017 at 05:27:57PM +0200, Christophe Fergeau wrote:
> > On Mon, Jun 12, 2017 at 12:19:51PM +0400, marcandre.lureau at redhat.com
> > wrote:
> > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > >
> > > Remove all the deprecated spice log macro/environment variables
> >
> > Note that the environment variables were never deprecated in a stable
> > release. Probably would be nice to keep them a bit longer, though I'd
> > be fine with degraded functionality (ie just handle what maps directly
> > to glib G_DEBUG/G_MESSAGES_DEBUG), so that spice_logger is no longer
> > needed.
> > Keeping the exact same behaviour of these env vars is the main reason
> > for the convoluted code that you are removing.
> >
> > Christophe
> 
> Considering that you have added a warning in efd1d3cb4d8eee [0] for
> SPICE_DEBUG_LEVEL in favor of G_MESSAGES_DEBUG In Jan 2016 and we have
> three releases with it, I don't see what's the problem to remove them
> after the next release (and mentioning that this release is the last
> supported with those variable(s) and user should do use
> G_DEBUG/G_MESSAGES_DEBUG from now on).
> 
> [0]
> https://gitlab.com/spice/spice-common/commit/efd1d3cb4d8eee#f67439a0d1276bbac550ebed2728be8ba7c2170c_82_67
> 
> It should simplify things a lot.
> 

Make sense, I would vote for it.
Getting to propose some patches.

Frediano