[Spice-devel] [PATCH spice-common 0/2] Remove obsolete environment usage

Jonathon Jongsma jjongsma at redhat.com
Tue Jun 13 15:55:32 UTC 2017


On Tue, 2017-06-13 at 16:53 +0200, Victor Toso wrote:
> Hi,
> 
> On Tue, Jun 13, 2017 at 03:47:52PM +0100, Frediano Ziglio wrote:
> > Following log discussion and Victor suggestion about removing
> > these variable as already enough obsolete and documented
> > proposed a patch to remove them.
> > Mainly to get some consent and votes.

Also note that these env variables (or at least the DEBUG_LEVEL one)
only ever worked (partially) on spice-server, and not on spice-gtk,
since it only enabled logging for the "Spice" domain.

> 
> +1, it would remove good amount of changes from Marc-André first
> patch.
> Did not test it yet ;)
> 
> > 
> > Frediano Ziglio (2):
> >   log: remove deprecated SPICE_ABORT_LEVEL support
> >   log: remove deprecated SPICE_DEBUG_LEVEL support
> > 
> >  common/log.c         | 107 +------------------------------------
> > --------------
> >  tests/test-logging.c |  95 -------------------------------------
> > --------
> >  2 files changed, 1 insertion(+), 201 deletions(-)
> > 
> > -- 
> > 2.9.4
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list