[Spice-devel] [PATCH spice-common 1/2] log: remove deprecated SPICE_ABORT_LEVEL support

[Jonathon Jongsma]

On Wed, 2017-06-14 at 11:51 -0400, Frediano Ziglio wrote:
> > 
> > On Wed, 2017-06-14 at 12:00 +0200, Victor Toso wrote:
> > > Hi,
> > > 
> > > On Tue, Jun 13, 2017 at 06:31:38PM +0200, Christophe Fergeau
> > > wrote:
> > > > On Tue, Jun 13, 2017 at 03:47:53PM +0100, Frediano Ziglio
> > > > wrote:
> > > > > This feature was marked obsolete by efd1d3cb4d8eee more than
> > > > > an year ago.
> > > > 
> > > > How many stable releases has this been in?
> > > 
> > > * Spice-gtk: v0.31, v0.32, v0.33 and I propose v0.34 as final.
> > > 
> > >   commit cc8adb63ee5b9a554b9e237f825741cf4fcc2c09
> > >   Author: Marc-André Lureau <marcandre.lureau at gmail.com>
> > >   Date:   Thu Mar 10 17:05:20 2016 +0100
> > > 
> > >       Update spice-common submodule
> > 
> > Unfortunately, these environment variables never really applied to
> > spice-gtk (even though it was ostensibly supposed to be a "common"
> > logging implementation). As I stated in a different email, defining
> > SPICE_DEBUG_LEVEL only enables debugging for the "Spice" domain,
> > which
> > is not used by spice-gtk ("GSpice" is the spice-gtk domain). In
> > theory,
> > SPICE_ABORT_LEVEL could affect spice-gtk, but only if spice-gtk
> > calls
> > spice_log(), which it generally doesn't. spice-gtk implements its
> > own
> > SPICE_DEBUG() macro that doesn't use spice_log(). So whether this
> > variable is kept or removed will not really affect spice-gtk at
> > all.
> > 
> 
> Not 100% correct. spice-gtk is using spice-common but not defining
> SPICE_LOG_DOMAIN and the default is "Spice". So the log calls to
> spice_XXX from spice-common code used by spice-gtk are using the
> spice_log path.

Good point. In practice this doesn't actually log much debug-level
information at all, though. And since spice-gtk defines
SPICE_DISABLE_ABORT in its Makefile, the SPICE_ABORT_LEVEL is not
really applicable to spice-gtk.

Jonathon