[Spice-devel] [PATCH spice-gtk] option: deprecate a few esoteric options from --spice group

[Marc-André Lureau]

Hi

----- Original Message -----
> On Thu, Jun 15, 2017 at 04:13:12PM +0400, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > 
> > I propose to deprecate the options that have very unclear results, or
> > that are unimplemented by drivers. They were added for historical
> > reasons, mostly to match with spicec options, but aren't
> > user-friendly. Some of them could be moved in spicy options or a new
> > debug/tune option group. For now, mark them as deprecated so they can
> > be removed in a future release.
> > 
> > Imho, --spice-preferred-compression is a good candidate too, although
> > users may be more familiar with this option, at least the 'off' case
> > may have a clear impact.
> > 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > ---
> >  man/spice-client.pod | 8 ++++----
> >  src/spice-option.c   | 8 ++++----
> >  2 files changed, 8 insertions(+), 8 deletions(-)
> > 
> > diff --git a/man/spice-client.pod b/man/spice-client.pod
> > index 69ea84c..cf22636 100644
> > --- a/man/spice-client.pod
> > +++ b/man/spice-client.pod
> > @@ -60,7 +60,7 @@ record, smartcard, usbredir.
> >  
> >  =item --spice-disable-effects=<wallpaper,font-smooth,animation,all>
> >  
> > -Disable guest display effects
> > +Disable guest display effects - DEPRECATED
> >  
> >  This tells the SPICE client that it should attempt to disable some guest
> >  features in order to lower bandwidth usage. This requires guest support,
> > @@ -74,7 +74,7 @@ can be disabled.
> >  
> >  =item --spice-color-depth=<16,32>
> >  
> > -Guest display color depth
> > +Guest display color depth - DEPRECATED
> >  
> >  This tells the SPICE client that it should attempt to force the guest OS
> >  color depth. A lower color depth should lower bandwith usage. This
> >  requires
> > @@ -164,13 +164,13 @@ should be used for smartcard emulation.
> 
> --spice-disable-effects/--spice-color-depth should still be supported by
> Windows guests, the Windows agent has support for these, but I did not
> test whether this had any real effect with win7 or newer.
> I'm fine with deprecating the other ones.

WDDM driver supports it on win7? Regarding win8: 

https://msdn.microsoft.com/en-us/library/windows/desktop/dd183413(v=vs.85).aspx:

"Apps that you design to target Windows 8 and later can no longer query or set display modes that are less than 32 bits per pixel (bpp)"

Imho we should more clearly state that we don't really support that feature moving forward.