[Spice-devel] [PATCH spice-gtk v2] option: deprecate a few esoteric options from --spice group

[Christophe Fergeau]

On Thu, Jun 15, 2017 at 10:08:46AM -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > On Thu, Jun 15, 2017 at 05:50:01PM +0400, marcandre.lureau at redhat.com wrote:
> > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > 
> > > I propose to deprecate the options that have very unclear results, or
> > > that are unimplemented by drivers. They were added for historical
> > > reasons, mostly to match with spicec options, but aren't
> > > user-friendly. Some of them could be moved in spicy options or a new
> > > debug/tune option group. For now, mark them as deprecated so they can
> > > be removed in a future release.
> > > 
> > > Imho, --spice-preferred-compression is a good candidate too, although
> > > users may be more familiar with this option, at least the 'off' case
> > > may have a clear impact.
> > > ---
> > >  man/spice-client.pod | 14 +++++++-------
> > >  src/spice-option.c   |  8 ++++----
> > >  2 files changed, 11 insertions(+), 11 deletions(-)
> > > 
> > > diff --git a/man/spice-client.pod b/man/spice-client.pod
> > > index 69ea84c..53d617d 100644
> > > --- a/man/spice-client.pod
> > > +++ b/man/spice-client.pod
> > > @@ -60,11 +60,11 @@ record, smartcard, usbredir.
> > >  
> > >  =item --spice-disable-effects=<wallpaper,font-smooth,animation,all>
> > >  
> > > -Disable guest display effects
> > > +Disable guest display effects - DEPRECATED
> > >  
> > >  This tells the SPICE client that it should attempt to disable some guest
> > > -features in order to lower bandwidth usage. This requires guest support,
> > > -usually through a SPICE agent. This is currently only supported on Windows
> > > +features in order to lower bandwidth usage. This requires guest support,
> > > usually
> > > +through a SPICE agent. This is currently only supported on Windows 7 and
> > > older
> > >  guests.
> > 
> > Are you sure we cannot disable wallpaper, animations, ... on new Windows
> > versions?
> 
> I would say it's fair to say it's unsupported if nobody ever tried :). But yeah, reading the API docs, it may work. I still question if we need to keep supporting this.
> 
> I don't mind if we don't state DEPRECATED for now, ack with the rest of the changes?

Yup,

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170615/9b09c1a9/attachment-0001.sig>