[Spice-devel] [PATCH spice-server] log: remove not widely used logging domain usage

Jonathon Jongsma jjongsma at redhat.com
Thu Jun 15 16:10:46 UTC 2017


No objections here. 

Acked-by: Jonathon Jongsma <jjongsma at redhat.com>



On Wed, 2017-06-14 at 17:16 +0100, Frediano Ziglio wrote:
> As discussed recently the usage of domain for logging has
> different issues (they are not filtered and handled coherently)
> and are not widely used in the code.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/dispatcher.c  | 2 --
>  server/lz4-encoder.c | 2 --
>  server/red-worker.c  | 2 --
>  3 files changed, 6 deletions(-)
> 
> diff --git a/server/dispatcher.c b/server/dispatcher.c
> index f4fe97b..fe14a3f 100644
> --- a/server/dispatcher.c
> +++ b/server/dispatcher.c
> @@ -26,8 +26,6 @@
>  #include <fcntl.h>
>  #include <poll.h>
>  
> -#define SPICE_LOG_DOMAIN "SpiceDispatcher"
> -
>  #include <common/mem.h>
>  #include <common/spice_common.h>
>  #include "dispatcher.h"
> diff --git a/server/lz4-encoder.c b/server/lz4-encoder.c
> index 9fabc35..1048349 100644
> --- a/server/lz4-encoder.c
> +++ b/server/lz4-encoder.c
> @@ -18,8 +18,6 @@
>  #include <config.h>
>  #endif
>  
> -#define SPICE_LOG_DOMAIN "SpiceLz4Encoder"
> -
>  #include <arpa/inet.h>
>  #include <lz4.h>
>  #include "red-common.h"
> diff --git a/server/red-worker.c b/server/red-worker.c
> index 57e6abe..e24d426 100644
> --- a/server/red-worker.c
> +++ b/server/red-worker.c
> @@ -19,8 +19,6 @@
>  #include <config.h>
>  #endif
>  
> -#define SPICE_LOG_DOMAIN "SpiceWorker"
> -
>  #include <stdio.h>
>  #include <stdarg.h>
>  #include <stdlib.h>


More information about the Spice-devel mailing list