[Spice-devel] [PATCH spice-server 00/22] reds: Use bool for boolean types

Frediano Ziglio fziglio at redhat.com
Fri Jun 16 09:13:12 UTC 2017


Different fields used "int" instead of a proper boolean type.
Switch to "bool" type and related mnemonics.
Some changesets should probable be squashed together (for instance
I would merge some migration field in RedsState) but is easier to
review.
"bool" is a bit smaller than "int"/"gboolean" so the structures
can be rearranges to use less bytes but I don't consider this
really important and is more suitable for a future optimization.

Frediano Ziglio (22):
  reds: use bool for RedsState::mm_time_latency
  reds: use bool for RedsState::allow_multiple_clients
  reds: use bool for RedsState::seamless_migration_enabled
  reds: use bool for RedsState::seamless_migration_enabled
  reds: use bool for RedsState::dispatcher_allows_client_mouse
  reds: use bool for RedsState::is_client_mouse_allowed
  reds: use bool for RedsState::dst_do_seamless_migrate
  reds: use bool for RedsState::src_do_seamless_migrate
  reds: use bool for RedsState::expect_migrate
  reds: use bool for RedsState::mig_inprogress
  reds: use bool for RedsState::mig_wait_disconnect
  reds: use bool for RedsState::mig_wait_connect
  reds: use bool for RedsState::pending_mouse_event
  reds: use true/false where bool is used
  reds: use bool for RedCharDeviceVDIPortPrivate::client_agent_started
  reds: use bool for RedCharDeviceVDIPortPrivate::agent_attached
  reds: use bool for
    RedCharDeviceVDIPortPrivate::recv_from_client_buf_pushed
  reds: use bool for RedServerConfig fields
  reds: use bool for reds_set_migration_dest_info
  reds: use bool instead of gboolean
  agent-msg-filter: use bool instead of gboolean
  reds: use SpiceMouseMode for RedsState::mouse_mode

 server/agent-msg-filter.c            |  10 +-
 server/agent-msg-filter.h            |  19 ++--
 server/main-channel-client.c         |   8 +-
 server/main-channel-client.h         |   4 +-
 server/main-channel.c                |   4 +-
 server/main-channel.h                |   2 +-
 server/reds-private.h                |  34 +++---
 server/reds.c                        | 208 +++++++++++++++++------------------
 server/reds.h                        |   4 +-
 server/tests/test-agent-msg-filter.c |  34 +++---
 10 files changed, 164 insertions(+), 163 deletions(-)

-- 
2.9.4



More information about the Spice-devel mailing list