[Spice-devel] [PATCH spice-server 06/22] reds: use bool for RedsState::is_client_mouse_allowed

[Christophe Fergeau]

On Fri, Jun 16, 2017 at 09:39:35AM -0400, Frediano Ziglio wrote:
> > 
> > On Fri, Jun 16, 2017 at 10:13:18AM +0100, Frediano Ziglio wrote:
> > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > > ---
> > >  server/main-channel-client.c | 4 ++--
> > >  server/main-channel-client.h | 2 +-
> > >  server/main-channel.c        | 2 +-
> > >  server/main-channel.h        | 2 +-
> > >  server/reds-private.h        | 2 +-
> > >  server/reds.c                | 2 +-
> > >  6 files changed, 7 insertions(+), 7 deletions(-)
> > > 
> > > diff --git a/server/main-channel-client.c b/server/main-channel-client.c
> > > index ae8d2d5..f741ed5 100644
> > > --- a/server/main-channel-client.c
> > > +++ b/server/main-channel-client.c
> > > @@ -332,7 +332,7 @@ void
> > > main_channel_client_push_agent_data(MainChannelClient *mcc, uint8_t* data,
> > >  static RedPipeItem *main_init_item_new(int connection_id,
> > >                                         int display_channels_hint,
> > >                                         int current_mouse_mode,
> > > -                                       int is_client_mouse_allowed,
> > > +                                       bool is_client_mouse_allowed,
> > >                                         int multi_media_time,
> > >                                         int ram_hint)
> > 
> > I haven't looked at the rest of the series yet, but this function is
> > doing
> > item->is_client_mouse_allowed = is_client_mouse_allowed;
> > so it might be worth changing the type of
> > RedInitPipeItem::is_client_mouse_allowed in this patch (or before?).
> > Not really important if this is split in a subsequent patch.
> > 
> > Christophe
> > 
> 
> Sooner or later before is sent to the network has to be converted to an
> integral value. I'll extend.

If the goal was to convert to an int value for sending on the network,
I'd expect a sized int to be used (eg uint8_t). The conversion for
network use will be done during marshalling, either in the autogenerated
code or in main_channel_marshall_init, here it's

if (item->is_client_mouse_allowed) {
    init.supported_mouse_modes |= SPICE_MOUSE_MODE_CLIENT;
}

so this really is a bool.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170616/4f1bace6/attachment.sig>