[Spice-devel] [PATCH spice-server 00/22] reds: Use bool for boolean types

[Christophe Fergeau]

On Fri, Jun 16, 2017 at 10:46:22AM -0400, Frediano Ziglio wrote:
> > 
> > On Fri, Jun 16, 2017 at 10:13:12AM +0100, Frediano Ziglio wrote:
> > > Different fields used "int" instead of a proper boolean type.
> > > Switch to "bool" type and related mnemonics.
> > > Some changesets should probable be squashed together (for instance
> > > I would merge some migration field in RedsState) but is easier to
> > > review.
> > > "bool" is a bit smaller than "int"/"gboolean" so the structures
> > > can be rearranges to use less bytes but I don't consider this
> > > really important and is more suitable for a future optimization.
> > 
> > Series looks good overall, going to cause some rebase pain though.. ;)
> > 
> > Christophe
> > 
> 
> Send a version 2 for 22/22 (SpiceMouseMode).
> 
> Should I consider acked?
> Should I merge some of them?

Since it's fairly invasive for, in my opinion, no huge gain, I'd wait a
bit in case other people have more feedback to give on this.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170616/cd12f421/attachment.sig>