[Spice-devel] [PATCH spice-gtk] Do not unrealize disabled egl

[Victor Toso]

Hi,

On Mon, Jun 19, 2017 at 11:50:45AM +0200, Pavel Grunt wrote:
> Avoids a critical to be logged when closing remote-viewer:
>  "gl_make_current: assertion 'd->egl.context_ready' failed"
> ---
>  src/spice-widget-egl.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
> index 7c21113..5951ae6 100644
> --- a/src/spice-widget-egl.c
> +++ b/src/spice-widget-egl.c
> @@ -374,6 +374,9 @@ void spice_egl_unrealize_display(SpiceDisplay *display)
>
>      DISPLAY_DEBUG(display, "egl unrealize %p", d->egl.surface);
>
> +    if (!d->egl.enabled)
> +        return;
> +

Although your patch is fine, spice_egl_unrealize_display() should not be
called, I think. Maybe use egl_enabled(d) before
spice_egl_unrealize_display() on spice-widget as well?

Cheers,


>      if (!gl_make_current(display, NULL))
>          return;
>  
> -- 
> 2.13.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170619/5a324c64/attachment.sig>