[Spice-devel] [PATCH spice-common] canvas-base: Do not attempt useless cast on stride adjustment
Christophe Fergeau
cfergeau at redhat.com
Wed Jun 21 07:41:29 UTC 2017
On Tue, Jun 20, 2017 at 08:39:44PM +0300, Uri Lublin wrote:
> On 06/20/2017 04:52 PM, Frediano Ziglio wrote:
> > memmove already deal with any alignment so there's no
> > reason to have row byte pointer cast to uint32_t.
>
> Hi Frediano,
>
> I think the code has no problem with memmove itself, but
> with the pointer used later being not-aligned (but only for
> non-x86 arch ?).
"later" ? The only uses of dest_aligned/dest_misaligned in this function
are as args to memmove, for which alignment does not matter.
Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170621/b4d79af0/attachment.sig>
More information about the Spice-devel
mailing list