[Spice-devel] [PATCH server] tests: Initialize all members of SpiceBaseInterface struct

Michal Privoznik mprivozn at redhat.com
Fri Jun 23 09:08:22 UTC 2017


On 06/23/2017 10:58 AM, Frediano Ziglio wrote:
> 
> <snip/>
> 
> You can update and post again or I can change before pushing it.
> 
> What about, simply:
> ******
> When compiling, -Werror=missing-field-initializers is enabled.
> However, some gcc versions (like Gentoo 4.9.4 one) fail to see
> that all the members of the SpiceBaseInterface struct are
> initialized:
> 
> test-display-base.c:844:5: error: missing initializer for field
> 'description' of 'SpiceBaseInterface'
> [-Werror=missing-field-initializers] .base.description   = "test
> spice virtual channel char device",
> 
> The solution is to initialize .base member as a structure at once
> instead of multiple times per each member.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ******
> 

Yup, this works for me too. Can you update it before pushing? It's a
small nit after all ;-)

Thanks,

Michal


More information about the Spice-devel mailing list