[Spice-devel] [PATCH spice-gtk v2 1/2] usb-device-widget: Fix parent class type

Frediano Ziglio fziglio at redhat.com
Mon Jun 26 10:18:09 UTC 2017


> 
> The widget is defined as GTK_TYPE_BOX, use GtkBox instead of GtkVBox.

Shouldn't you set the orientation to vertical too? I think the default
is horizontal.
Not that I think something would change, there are no reference to GtkVBox,
only GtkBox so this seems more of a fix to me.

> ---
>  src/usb-device-widget.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c
> index b394499..747887c 100644
> --- a/src/usb-device-widget.c
> +++ b/src/usb-device-widget.c
> @@ -40,14 +40,14 @@
>  
>  struct _SpiceUsbDeviceWidget
>  {
> -    GtkVBox parent;
> +    GtkBox parent;
>  
>      SpiceUsbDeviceWidgetPrivate *priv;
>  };
>  
>  struct _SpiceUsbDeviceWidgetClass
>  {
> -    GtkVBoxClass parent_class;
> +    GtkBoxClass parent_class;
>  
>      /* signals */
>      void (*connect_failed) (SpiceUsbDeviceWidget *widget,

Patch looks good to me, just not an expert of either this widget
and Gtk.

Frediano


More information about the Spice-devel mailing list