[Spice-devel] [PATCH spice-gtk v3 5/6] display-gst: check GstRegistry for decoding elements

[Victor Toso]

Hi,

On Tue, Jun 27, 2017 at 04:39:45PM +0200, Victor Toso wrote:
> > Why is this limited to gstreamer 1.9 and newer? (a small note in the
> > comit log could probably be helpful)
>
> From what was explained to me, since 1.9.0 the GStreamer got smarter to
> deal with vaapi elements first. That matters on the playbin patch but
> not here.
>
> Here we list the elements based on GstCaps. That should work prior 1.9.0
> just fine.
>
> So, to answer your question, the only need for checking
> GST_CHECK_VERSION(1,9,0) is due the ifdef in the array of capabilities
> itself - gst_opts[].

Sorry, I replied this information by head. Checking the code, we don't
have ifdef on gst_opts[] so we can drop this ifdef too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170627/54344dfd/attachment.sig>