[Spice-devel] [PATCH spice-gtk v4 1/7] display-gst: check codec type before creating decoder

[Pavel Grunt]

On Wed, 2017-06-28 at 14:42 +0200, Victor Toso wrote:
> From: Victor Toso <me at victortoso.com>
> 
> Inserting this check in channel-display-gst.c as the GStreamer
> decoder
> is the only one handling all the different video formats supported
> by
> spice-protocol.
> 
> If a unsupported/bad codec type value was sent, spice-gtk will fail
> to
> create the decoder and any messages related to this stream-id will
> be
> ignored.
> 
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> Signed-off-by: Victor Toso <me at victortoso.com>

Acked-by: Pavel Grunt <pgrunt at redhat.com>

It is a programmer error. The programmer should check for the codec
type in display_stream_create()

Pavel

> ---
>  src/channel-display-gst.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
> index 9b79403..d3e83e3 100644
> --- a/src/channel-display-gst.c
> +++ b/src/channel-display-gst.c
> @@ -512,6 +512,8 @@ VideoDecoder* create_gstreamer_decoder(int
> codec_type, display_stream *stream)
>  {
>      SpiceGstDecoder *decoder = NULL;
>  
> +    g_return_val_if_fail(VALID_VIDEO_CODEC_TYPE(codec_type), NULL);
> +
>      if (gstvideo_init()) {
>          decoder = spice_new0(SpiceGstDecoder, 1);
>          decoder->base.destroy = spice_gst_decoder_destroy;