[Spice-devel] [PATCH 0/2] nitpicking on streaming

[Victor Toso]

From: Victor Toso <me at victortoso.com>

Not sure if by design we want to get rid of all access to private structure of
display-channel outside display-channel.c, see:

$ grepi "display->priv" server/ | grep -v "display-channel\.c"
server/dcc.c:308:    surface = &display->priv->surfaces[surface_id];
server/dcc.c:325:    RedSurface *surface = &display->priv->surfaces[surface_id];
server/dcc.c:391:    surface = &display->priv->surfaces[surface_id];
server/dcc.c:579:    if (display->priv->surfaces[0].context.canvas) {
server/dcc.c:1364:            display->priv->enable_jpeg = TRUE;
server/dcc.c:1367:            display->priv->enable_zlib_glz_wrap = TRUE;
server/dcc.c:1372:    surfaces_restored = display->priv->enable_jpeg ?
server/dcc-send.c:98:    surface = &display->priv->surfaces[surface_id];
server/dcc-send.c:384:                if (!display->priv->enable_jpeg || lossy_cache_item) {
server/dcc-send.c:396: stat_inc_counter(display->priv->cache_hits_counter, 1);
server/dcc-send.c:419:        surface = &display->priv->surfaces[surface_id];
server/dcc-send.c:2141:    if (display->priv->enable_jpeg)
server/stream.c:126:    display->priv->streams_size_total -= stream->width * stream->height;
server/stream.c:133:    stream->next = display->priv->free_streams;
server/stream.c:134:    display->priv->free_streams = stream;
server/stream.c:141:    ring_init(&display->priv->streams);
server/stream.c:142:    display->priv->free_streams = NULL;
server/stream.c:158:    display->priv->stream_count--;
server/stream.c:373:    if (!display->priv->free_streams) {
server/stream.c:376:    stream = display->priv->free_streams;
server/stream.c:377:    display->priv->free_streams = display->priv->free_streams->next;
server/stream.c:397:    ring_add(&display->priv->streams, &stream->link);
server/stream.c:419:    display->priv->streams_size_total += stream->width * stream->height;
server/stream.c:420:    display->priv->stream_count++;
server/stream.c:497:    trace = display->priv->items_trace;
server/stream.c:882:    Ring *ring = &display->priv->streams;
server/stream.c:918:    while ((stream_item = ring_get_head(&display->priv->streams))) {
server/stream.c:928:    Ring *ring = &display->priv->streams;
server/stream.c:951:    trace = &display->priv->items_trace[display->priv->next_item_trace++ & ITEMS_TRACE_MASK];

Cheers,

Victor Toso (2):
  stream: use display_channel_get_stream_id()
  display-channel: introduce display_channel_get_nth_stream()

 server/dcc.c             | 2 +-
 server/display-channel.c | 5 +++++
 server/display-channel.h | 1 +
 server/stream.c          | 4 ++--
 4 files changed, 9 insertions(+), 3 deletions(-)

-- 
2.13.0