[Spice-devel] [PATCH spice-gtk v3] Switch over to using keycodemapdb submodule

[Pavel Grunt]

On Mon, 2017-02-27 at 10:44 +0000, Daniel P. Berrange wrote:
> On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote:
> > Hello Daniel,
> > 
> > On Mon, 2017-02-27 at 10:25 +0000, Daniel P. Berrange wrote:
> > > Consume the keymaps.csv file from a git submodule instead of
> > > having
> > > a private copy. This makes it easier to ensure all users of the
> > > keymap
> > > (libvirt, gtk-vnc, spice-gtk, and eventually QEMU) to have a
> > > consistent
> > > set of data.
> > > 
> > 
> > besides that it also allow us to drop the dependency on perl (also
> > perl-Text-CSV is not packaged in some distros)
> 
> True yes, I intentionally kept the python code so that it only
> used modules base-python installs so we don't rely on external
> modules from pypi.
> 
> > Are there contributing rules for the keycodemapdb (where to send
> > the
> > patches etc.)?
> 
> Just send pull requests to the repo is best I think. I don't think
> we'd
> have enough traffic to warrant creating a new mailing list. In any
> case I would expect that most bug reports would start off with a
> mail
> and/or bug report to a project using the module. eg a mail on spice-
> devel,
> so there's little point trying to artificially move discussion to a
> dedicated list.
> 
> I'm happy to add any of the people with experiance of this code to
> the
> admins/committers list of the gitlab project too, so I'm not a
> potential
> bottleneck.
Feel free to add me (nickname "xerus")

> 
> > (For the future) Do you consider adding the vncdisplaykeymap.[ch]
> > to
> > the repo ?
> 
> I'm unsure of the direction to take for that at this time. It would
> certainly be interesting to look at sharing that logic. For sharing
> code though, I wonder if its better to create a libgtkkeycodemap.so
> library rather than do a sub-module thing for that code too.
we have both ways in spice-common

About the patch - the generated file are not the same (I used git diff
--word-diff)

xorgkbd2xtkbd - empty
xorgxquartz2xtkbd - some values are different

Pavel

https://paste.fedoraproject.org/paste/N9n1q2y3dZHDNhMOaIA5c15M1UNdIGYh
yRLivL9gydE=

> 
> Regards,
> Daniel