[Spice-devel] [spice-gtk v3 0/6] spice-channel: read/flush wire functions

[Victor Toso]

Hi,

On Tue, Feb 28, 2017 at 12:21:45PM +0100, Victor Toso wrote:
> From: Victor Toso <me at victortoso.com>
> 
> Hi,
> 
> v2->v3:
> * Breaking spice_channel_read_wire() into smaller changes. (teuf)
> 
> v2: https://lists.freedesktop.org/archives/spice-devel/2017-February/035455.html
> v1: https://lists.freedesktop.org/archives/spice-devel/2017-February/035446.html
> 
> Cheers,
> 
> Victor Toso (6):
>   spice-channel: move out non blocking logic of _read_wire()
>   spice-channel: move out non blocking logic of _flush_wire()
>   spice_channel_read_wire: prefer while(TRUE) instead of goto
>   spice_channel_read_wire: move variables to internal scope

Any feedback on 3/6 and 4/6 ? I don't mind dropping the 5/6 and 6/6
patches at all. They don't bring much benefit and it might be just
personal preference.

Cheers!

>   spice_channel_read_wire: return earlier whenever is possible
>   spice_channel_flush_wire: make it similar to _read_wire()
> 
>  src/spice-channel.c | 172 +++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 108 insertions(+), 64 deletions(-)
> 
> --
> 2.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170302/7c23d0c6/attachment.sig>