[Spice-devel] [PATCH spice-server v3 4/5] red-channel-capabilities: Enhance

[Christophe Fergeau]

On Thu, Mar 02, 2017 at 07:03:55AM -0500, Frediano Ziglio wrote:
> I used TYPE_RED_CHANNEL_CAPABILITIES define, seems more consistent with
> other code and keep the "RedChannel" together.

I disagree, RedChannel is for example RED_TYPE_CHANNEL, not
TYPE_RED_CHANNEL.
The way I see it is that 'red' (and sometimes 'reds' or 'spice') is our
namespace, just like 'g' is glib's namespace. So just like we have
G_TYPE_OBJECT, we should use RED_TYPE_XXX

We happen to have various objects with no namespace (sndchannel, ...),
in this case the types are indeed TYPE_XXX. I would not encourage
types without the red namespace, but TYPE_RED is definitely not correct.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170302/a4ff5346/attachment.sig>