[Spice-devel] [PATCH spice-server 3/3] tests: Reuse GLib compatibility code

[Frediano Ziglio]

> 
> On Thu, Mar 02, 2017 at 01:50:03PM +0000, Frediano Ziglio wrote:
> > Instead of disabling the code use the compatibility functions.
> > 
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/tests/test-codecs-parsing.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/server/tests/test-codecs-parsing.c
> > b/server/tests/test-codecs-parsing.c
> > index 571d8ab..838a80c 100644
> > --- a/server/tests/test-codecs-parsing.c
> > +++ b/server/tests/test-codecs-parsing.c
> > @@ -46,8 +46,9 @@ static void codecs_good(void)
> >  }
> >  
> >  /* g_test_expect_message is available since Glib 2.34 */
> > -#if GLIB_CHECK_VERSION(2, 34, 0)
> > +#ifdef G_GNUC_BEGIN_IGNORE_DEPRECATIONS
> >  G_GNUC_BEGIN_IGNORE_DEPRECATIONS
> > +#endif
> 
> Not consistent with what was done for test-vdagent which uses
> -UGLIB_MAX_VERSION in Makefile.am.
> If this form is preferred over disabling the version checks, I'll send a
> patch for test-vdagent.
> 
> Christophe
> 

I'll copy vdagent way

Frediano