[Spice-devel] [PATCH spice-server v4 3/3] red-channel: Use RedChannelCapabilities directly to pass capabilities

Christophe Fergeau cfergeau at redhat.com
Thu Mar 2 15:22:55 UTC 2017


On Thu, Mar 02, 2017 at 10:15:15AM -0500, Frediano Ziglio wrote:
> > Not really a big fan of having this kind of functions because we use
> > stack-allocated struct rather than just allocating a new struct. This
> > function should only be used on non-initialized RedChannelCapabilities
> > (this will leak otherwise), but it's non-obvious from the function name.
> > 
> 
> Maybe red_channel_capabilities_init_from_link_message ?

Better I guess,

Christophe

> 
> > 
> > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > 
> > Christophe
> > 
> 
> Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170302/b0348df9/attachment.sig>


More information about the Spice-devel mailing list