[Spice-devel] [PATCH spice-server v4 2/3] red-channel: Separate RedChannelCapabilities

[Jonathon Jongsma]

On Thu, 2017-03-02 at 16:04 +0100, Christophe Fergeau wrote:
> On Thu, Mar 02, 2017 at 09:55:46AM -0500, Frediano Ziglio wrote:
> > > > +/* GObject type that can be used to box RedChannelCapabilities
> > > > */
> > > > +extern GType red_channel_capabilities_type;
> > > > +#define TYPE_RED_CHANNEL_CAPABILITIES
> > > > red_channel_capabilities_type
> > > 
> > > RED_TYPE_CHANNEL_CAPABILITIES, similarly to RED_TYPE_CHANNEL,
> > > RED_TYPE_CHANNEL_CLIENT, ...
> > > 
> > 
> > If you do some grep the TYPE_xxx win (not much).
> 
> But there are 0 TYPE_RED_xxx.
> The scheme really is
> $NAMESPACE_TYPE_$TYPENAME, if NAMESPACE is empty, then TYPE_$TYPENAME
> We don't use TYPE_$NAMESPACE_$TYPENAME
> 

I agree with Christophe. It should be RED_TYPE_FOO for all types in the
Red namespace.

Jonathon