[Spice-devel] [PATCH spice-server] Remove call to red_channel_client_push outside RedChannel

Frediano Ziglio fziglio at redhat.com
Fri Mar 3 15:10:50 UTC 2017


Now the push is done automatically when a PipeItem is added,
forcing a push cause only network fragmentation and is required
only of you are handling data in a loop instead of using the
default loop.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 server/dcc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/server/dcc.c b/server/dcc.c
index 898e074..db18bbb 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -395,7 +395,6 @@ void dcc_push_surface_image(DisplayChannelClient *dcc, int surface_id)
     /* not allowing lossy compression because probably, especially if it is a primary surface,
        it combines both "picture-like" areas with areas that are more "artificial"*/
     dcc_add_surface_area_image(dcc, surface_id, &area, NULL, FALSE);
-    red_channel_client_push(RED_CHANNEL_CLIENT(dcc));
 }
 
 static void add_drawable_surface_images(DisplayChannelClient *dcc, Drawable *drawable)
@@ -675,7 +674,6 @@ void dcc_push_monitors_config(DisplayChannelClient *dcc)
     mci = red_monitors_config_item_new(red_channel_client_get_channel(RED_CHANNEL_CLIENT(dcc)),
                                        monitors_config);
     red_channel_client_pipe_add(RED_CHANNEL_CLIENT(dcc), &mci->pipe_item);
-    red_channel_client_push(RED_CHANNEL_CLIENT(dcc));
 }
 
 static RedSurfaceDestroyItem *red_surface_destroy_item_new(RedChannel *channel,
-- 
2.9.3



More information about the Spice-devel mailing list