[Spice-devel] [spice v1] syntax-check: Fix missing AUTHORS

[Victor Toso]

Hi,

On Tue, Feb 28, 2017 at 01:44:42PM +0000, Daniel P. Berrange wrote:
> On Tue, Feb 28, 2017 at 02:37:25PM +0100, Victor Toso wrote:
> > From: Victor Toso <me at victortoso.com>
> > 
> > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > ---
> >  AUTHORS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/AUTHORS b/AUTHORS
> > index 2b0fe24..99f6c18 100644
> > --- a/AUTHORS
> > +++ b/AUTHORS
> > @@ -28,6 +28,7 @@ Patches also contributed by
> >      소병철 <byungchul.so at samsung.com>
> >      Cédric Bosdonnat <cbosdonnat at suse.com>
> >      Christian Ruppert <idl0r at qasl.de>
> > +    Christophe de Dinechin <dinechin at redhat.com>
> >      Cole Robinson <crobinso at redhat.com>
> >      Daniel P. Berrange <berrange at redhat.com>
> >      Dan Kenigsberg <danken at redhat.com>
>
> FWIW, git can trivially auto-fill an AUTHORS file at make dist time.
> Libvirt does it as follows:
>
> Rename AUTHORS to AUTHORS.in, replace the names beneath the
> "Patches also contributed by" line, with "#authorslist#" then
> add to Makefile.am
>
> dist-hook: gen-AUTHORS
>
> .PHONY: gen-AUTHORS
> gen-AUTHORS:
>         $(AM_V_GEN)if test -d $(srcdir)/.git; then \
>             out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>' | sort -u`" && \
>             perl -p -e "s/#authorslist#// and print '$$out'" \
>               < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \
>             mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS ; \
>         fi
>
> Regards,
> Daniel

Ah, sorry, forgot to reply to this.

Yes, I'm just being lazy to patch this in better way like your
suggestion. FWIW grilo-plugins has this release.mk file that works fine
too

https://git.gnome.org/browse/grilo-plugins/tree/release.mk

Cheers,
        toso

> --
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170306/013cfaf8/attachment-0001.sig>