[Spice-devel] [PATCH spice-gtk] build-sys: Add webdav_support variable to spice-client-glib-2.0.pc

[Marc-André Lureau]

Hi

----- Original Message -----
> On 03/03/17 18:42, Marc-André Lureau wrote:
> > Hi
> > 
> > ----- Original Message -----
> >> This allows us to inform the clients of this library if it was built
> >> with support for folder sharing or not.
> >>
> >> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> > 
> > Interesting approach, but you should rather do that at run time. This would
> > allow to dynamically replace the shared library without recompiling.
> > 
> > You can do spice_session_get_webdav_server() to know if it's enabled, for
> > example
> 
> Well, my idea was to check for this at configure time and completely
> avoid the build of related source code that would make use of this feature.

What's the point if you can check it a runtime? You may save a few function to compile, but you lose the flexibility of changing the library without recompiling the project: runtime wins.