[Spice-devel] [spice (stable)] Resending volume value on migration

[Frediano Ziglio]

> Hi,
> 
> On Tue, Feb 28, 2017 at 11:18:15AM +0100, Victor Toso wrote:
> > Hi,
> >
> > On Tue, Feb 28, 2017 at 04:56:54AM -0500, Frediano Ziglio wrote:
> > > > 
> > > > From: Victor Toso <me at victortoso.com>
> > > > 
> > > > Hi,
> > > > 
> > > > This patch is actually an improvement of an old patch [0]. It fixes
> > > > rhbz#1425443
> > > > here. I'm sending this for stable branch only as we might have a better
> > > > way
> > > > to
> > > > do it on the current master as a lot has been improved.
> > > > 
> > > > [0]
> > > > https://lists.freedesktop.org/archives/spice-devel/2015-April/019605.html
> > > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1425443
> > > > 
> > > > Let me know if this seems good enough for stable branch.
> > > > 
> > > > Victor Toso (1):
> > > >   sound: do not change volume or mute state on migration
> > > > 
> > > >  server/snd_worker.c | 12 ++++++++++++
> > > >  1 file changed, 12 insertions(+)
> > > > 
> > >
> > > Patch looks good.
> > > Didn't manage to test (I never managed to try a migration, my fault).
> > > What do you mean by stable branch? 0.13.3 or 0.12.8 ?
> > 
> > 0.12 branch which has the stable releases, 0.12.8 being the last one!
> > In git master, this volume-jumps are much improved in my tests but I
> > didn't manage to try migration with upstream yet.
> >
> > Cheers,
> >         toso
> 
> Just to confirm. I just tested spice from git master in the same
> environment of rhbz#1425443 and I did not see any volume-jump.
> 
> Sounds good to have this in the stable branch only?
> 
>         toso
> 

This quite surprise me. I really don't understand how we manage to
fix this? Did we fix as regression? Looks like sometimes a regression
could be even a good thing :-)
Mumble... maybe the old was sending mute+volume while now we just send
volume? Or something like that? Can you see if there is a difference
in the messages sent by 0.12 and 0.13?

Frediano