[Spice-devel] [PATCH spice-html5] When offered multiple heads, generate a warning, rather than failing in subtle ways.

Pavel Grunt pgrunt at redhat.com
Tue Mar 7 19:28:16 UTC 2017


ACK

Thanks,
Pavel

On Tue, 2017-03-07 at 13:08 -0600, Jeremy White wrote:
> Signed-off-by: Jeremy White <jwhite at codeweavers.com>
> ---
>  main.js | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/main.js b/main.js
> index 2d8a1ff..173ff97 100644
> --- a/main.js
> +++ b/main.js
> @@ -145,7 +145,12 @@ SpiceMainConn.prototype.process_channel_message
> = function(msg)
>                          chan_id : chans.channels[i].id
>                      };
>              if (chans.channels[i].type == SPICE_CHANNEL_DISPLAY)
> -                this.display = new SpiceDisplayConn(conn);
> +            {
> +                if (this.display !== undefined)
> +                    this.log_warn("The spice-html5 client does not
> handle multiple heads.");
> +                else
> +                    this.display = new SpiceDisplayConn(conn);
> +            }
>              else if (chans.channels[i].type ==
> SPICE_CHANNEL_INPUTS)
>              {
>                  this.inputs = new SpiceInputsConn(conn);


More information about the Spice-devel mailing list