[Spice-devel] [spice-server 1/3] reds-stream: Introduce reds_stream_set_no_delay() helper

Christophe Fergeau cfergeau at redhat.com
Thu Mar 9 11:22:20 UTC 2017


On Thu, Mar 09, 2017 at 06:12:47AM -0500, Frediano Ziglio wrote:
> > 
> > That's a good point, red-socket.c? Though if it grows too close to
> > GSocket, I'd probably just use that.
> > 
> 
> They are so low level that even the red prefix is strong (at least in
> file name).
> Maybe just net-utils.c ?

Oh for me everything shipped in spice/server is red-something.c, I don't
really think further than that ;) but I don't really mind about the
naming.

> > I'll drop this series then, and see how to do it differently ;)
> > 
> 
> Looks strong... all I'm suggesting is moving the functions,
> change a parameter to int socket and renames them...

ah, badly worded, I'll drop the series as it is now, and rework it to be
closer to what you suggest :) Since you prefer the bool changes to come
first, that means a good excuse for reordering things.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170309/42423dbb/attachment.sig>


More information about the Spice-devel mailing list