[Spice-devel] [spice (stable)] Resending volume value on migration

[Victor Toso]

On Thu, Mar 09, 2017 at 08:30:38AM -0500, Frediano Ziglio wrote:
> > I'm glad that you asked :)
> >
> > On my first tests I was only paying attention to the volume bar in the
> > client and in the guest. After migration I would see it move in the
> > client with 0.12.4 but not with 0.13.3.
> >
>
> I assume you are using the same exact Qemu/libvirt/rhv infrastructure,
> just changing spice-server.

Yes

> > Might be a regression, I've filed:
> > https://bugs.freedesktop.org/show_bug.cgi?id=100136
> >
> > In the logs that I've filed, looking into the client you can see that
> > with 0.12.4 we got:
> >
> > spice-session.c:1806 main-1:0: migration: all channel migrated, success
> > ...
> > spice-session.c:1743 no migration in progress
> > ...
> > spice-channel.c:2330 playback-5:0: unfreeze channel
> > ...
> > spice-channel.c:2642 playback-5:0: Coroutine exit playback-5:0
> > ...
> > /* Bellow is the bug that I'm trying to fix with this patch */
> > spice-pulse.c:730 record volume changed 65536
> > spice-pulse.c:730 record volume changed 65536
> > spice-gtk-session.c:203 inputs-3:0: client_modifiers:0x2, guest_modifiers:0x0
> > spice-pulse.c:622 playback volume changed 65536
> > spice-pulse.c:622 playback volume changed 65536
> > ...
> > channel-playback.c:371 playback-5:0: playback_handle_start: fmt 1 channels 2
> > freq 44100 time 243933442
> >
>
> There is something I don't understand from this log.
> Seems that the volume is sent after the migration is completed which
> seems nothing wrong to me.

Spice server should send the volume only if the volume in the guest has
changed. Sending it when the volume has not changed might cause problems
in the client machine as we will reset the application volume with this
value. The problem appears when the client might have changed the
client-volume himself and he is not expecting it to change during
migration.

> But from the original patch it seems that the server still thinks is
> migrating.

Yes, I'm not sure how that all works. I think this might be happening
during migration, while the new host is starting? AFAIK, the messages
are not sent right away to the client, only after the migration is
complete. Its a guess, I could be wrong... I never understood migration
fully.

>
> > --
> > 
> > Now, the same is not true with 0.13.3+ (upstream) as after `coroutine
> > exit playback` we don't receive neither the volume messages nor the
> > 
> 
> the ? :)

Oh, I did not noticed that I cut that part off.
"The playback_handle_start message!"

> 
> > Cheers,
> >         toso
> > 
> 
> Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170309/214c33bd/attachment.sig>