[Spice-devel] [spice-server 1/4] Remove stdbool.h include from .c files
Frediano Ziglio
fziglio at redhat.com
Thu Mar 9 14:09:38 UTC 2017
>
> It's already included in red-common.h
Acked-by: Frediano Ziglio <fziglio at redhat.com>
All headers are still self independent.
This patch does not follow "include if used directly" but I
personally don't mind for system headers.
> ---
> server/inputs-channel.c | 1 -
> server/red-parse-qxl.c | 1 -
> server/red-record-qxl.c | 1 -
> server/red-replay-qxl.c | 1 -
> server/reds-stream.h | 1 -
> server/reds.c | 1 -
> 6 files changed, 6 deletions(-)
>
> diff --git a/server/inputs-channel.c b/server/inputs-channel.c
> index 98413e5..84056ad 100644
> --- a/server/inputs-channel.c
> +++ b/server/inputs-channel.c
> @@ -20,7 +20,6 @@
> #endif
>
> #include <stddef.h> // NULL
OT: Do we need this?
> -#include <stdbool.h>
> #include <spice/macros.h>
> #include <spice/vd_agent.h>
> #include <spice/protocol.h>
> diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c
> index 89cb120..d0d7d6d 100644
> --- a/server/red-parse-qxl.c
> +++ b/server/red-parse-qxl.c
> @@ -19,7 +19,6 @@
> #include <config.h>
> #endif
>
> -#include <stdbool.h>
> #include <inttypes.h>
> #include <glib.h>
> #include <common/lz_common.h>
> diff --git a/server/red-record-qxl.c b/server/red-record-qxl.c
> index e687c68..21ff964 100644
> --- a/server/red-record-qxl.c
> +++ b/server/red-record-qxl.c
> @@ -19,7 +19,6 @@
> #include <config.h>
> #endif
>
> -#include <stdbool.h>
> #include <inttypes.h>
> #include <glib.h>
> #include "red-common.h"
> diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
> index 8c52e51..6915f00 100644
> --- a/server/red-replay-qxl.c
> +++ b/server/red-replay-qxl.c
> @@ -19,7 +19,6 @@
> #include <config.h>
> #endif
>
> -#include <stdbool.h>
> #include <inttypes.h>
> #include <zlib.h>
> #include <pthread.h>
> diff --git a/server/reds-stream.h b/server/reds-stream.h
> index 3a4aa25..b6aa338 100644
> --- a/server/reds-stream.h
> +++ b/server/reds-stream.h
> @@ -18,7 +18,6 @@
> #ifndef _H_REDS_STREAM
> #define _H_REDS_STREAM
>
> -#include <stdbool.h>
> #include <openssl/ssl.h>
> #include <common/mem.h>
>
> diff --git a/server/reds.c b/server/reds.c
> index 2ad231e..30d6372 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -34,7 +34,6 @@
> #include <fcntl.h>
> #include <errno.h>
> #include <ctype.h>
> -#include <stdbool.h>
>
> #include <openssl/err.h>
>
Frediano
More information about the Spice-devel
mailing list