[Spice-devel] [spice-server 4/4] RedChannelClient: Mark some private data as boolean
Christophe Fergeau
cfergeau at redhat.com
Thu Mar 9 14:39:52 UTC 2017
On Thu, Mar 09, 2017 at 09:16:51AM -0500, Frediano Ziglio wrote:
> >
> > ---
> > server/red-channel-client.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/server/red-channel-client.c b/server/red-channel-client.c
> > index 63877ab..47583c7 100644
> > --- a/server/red-channel-client.c
> > +++ b/server/red-channel-client.c
> > @@ -133,15 +133,15 @@ struct RedChannelClientPrivate
> > } urgent;
> > } send_data;
> >
> > - int during_send;
> > + gboolean during_send;
> > GQueue pipe;
> >
> > RedChannelCapabilities remote_caps;
> > - int is_mini_header;
> > + gboolean is_mini_header;
> > gboolean destroying;
> >
> > - int wait_migrate_data;
> > - int wait_migrate_flush_mark;
> > + gboolean wait_migrate_data;
> > + gboolean wait_migrate_flush_mark;
> >
> > RedChannelClientLatencyMonitor latency_monitor;
> > RedChannelClientConnectivityMonitor connectivity_monitor;
>
> I would stick to bool even if properties are used.
Ah correct, this one just aimed to keep consistency with what is already
being done (see 'gboolean destroying'), this was before the bool vs
gboolean discussion I think. I can change it.
Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170309/37439729/attachment.sig>
More information about the Spice-devel
mailing list