[Spice-devel] [PATCH spice-protocol 1/2] Add support for reporting availability of agent features

[Victor Toso]

Hi,

On Fri, Mar 10, 2017 at 09:07:14AM +0100, Pavel Grunt wrote:
> On Tue, 2017-02-28 at 15:07 +0100, Victor Toso wrote:
> > Hi,
> > 
> > On Tue, Feb 28, 2017 at 02:58:58PM +0100, Pavel Grunt wrote:
> > > Some agent features can be disabled on the server:
> > >  * Copy & Paste
> > >  * File transfer
> > > 
> > > Add the agent capability to inform about disabled file transfer.
> > > 
> > > Related:
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1373725
> > 
> > I did not ack this back in December [0] just because I thought you
> > would
> > send a new version with some improvements in the server side.
> > 
> > [0] https://lists.freedesktop.org/archives/spice-devel/2016-December
> > /034719.html
> > 
> > Both protocol patches are fine to me and we can include them before
> > the
> > release, but it would be great to have the bits that implement this
> > in
> > too.
> > 
> I would change the commit message to:
> 
>     agent: Add capability for disabled file transfer
>     
>     Server can set it to indicate that it discards file transfer
>     messages.
>     
>     Related:
>     https://bugzilla.redhat.com/show_bug.cgi?id=1373725

Sure, looks fine
>     
> 
> > Acked-by: Victor Toso <victortoso at redhat.com>
> > 
> > Cheers,
> > 
> > > ---
> > >  spice/vd_agent.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/spice/vd_agent.h b/spice/vd_agent.h
> > > index 061ca30..ac22498 100644
> > > --- a/spice/vd_agent.h
> > > +++ b/spice/vd_agent.h
> > > @@ -247,6 +247,7 @@ enum {
> > >      VD_AGENT_CAP_MAX_CLIPBOARD,
> > >      VD_AGENT_CAP_AUDIO_VOLUME_SYNC,
> > >      VD_AGENT_CAP_MONITORS_CONFIG_POSITION,
> > > +    VD_AGENT_CAP_FILE_XFER_DISABLED,
> > >      VD_AGENT_END_CAP,
> > >  };
> > >  
> > > -- 
> > > 2.11.1
> > > 
> > > _______________________________________________
> > > Spice-devel mailing list
> > > Spice-devel at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170310/f2ac072f/attachment.sig>