[Spice-devel] [spice-server] build-sys: Add tests/pki to EXTRA_DIST

Daniel P. Berrange berrange at redhat.com
Fri Mar 10 12:31:37 UTC 2017


On Fri, Mar 10, 2017 at 01:16:37PM +0100, Christophe Fergeau wrote:
> This fixes make distcheck
> ---
> This applies on top of the make check-valgrind patch I sent earlier, I can
> rebase on top of git master if needed
> 
> Christophe
> 
>  server/tests/Makefile.am | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
> index 86977ab..8237138 100644
> --- a/server/tests/Makefile.am
> +++ b/server/tests/Makefile.am
> @@ -2,7 +2,12 @@ NULL =
>  
>  @VALGRIND_CHECK_RULES@
>  VALGRIND_SUPPRESSIONS_FILES = $(top_srcdir)/server/tests/valgrind/glib.supp
> -EXTRA_DIST = $(VALGRIND_SUPPRESSIONS_FILES)
> +EXTRA_DIST =				\
> +	$(VALGRIND_SUPPRESSIONS_FILES)	\
> +	pki/ca-cert.pem			\
> +	pki/server-cert.pem		\
> +	pki/server-key.pem		\
> +	$(NULL)

Unless i'm mistaken you have a timebomb there that will break the tests
in about 1 & 1/2 years time

$ certtool  -i --infile server/tests/pki/server-cert.pem  | grep --after 2 Validity
	Validity:
		Not Before: Sun Mar 05 15:51:44 UTC 2017
		Not After: Fri Nov 29 15:51:44 UTC 2019


The ca-cert.pem is valid until 2044 by which time y2038 will have destroyed
the world, so that's ok.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|


More information about the Spice-devel mailing list