[Spice-devel] [PATCH spice-gtk] dist: Keep generated keymaps

[Pavel Grunt]

On Fri, 2017-03-10 at 15:07 +0100, Christophe Fergeau wrote:
> On Fri, Mar 10, 2017 at 12:58:40PM +0100, Pavel Grunt wrote:
> > spice-gtk does not have to require python
> > 
> > Regression since 271222e2217bf82644d87649b43b920240430f8
> 
> 
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> though I wonder whether we should always regenerate the keymaps .c
> files
> instead.

I think it is nice that we don't require python/perl/... We can change
it, but I don't see a benefit.

> 
> > ---
> >  src/Makefile.am | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/Makefile.am b/src/Makefile.am
> > index 594c0de..40cffa6 100644
> > --- a/src/Makefile.am
> > +++ b/src/Makefile.am
> > @@ -31,6 +31,7 @@ BUILT_SOURCES = $(GLIBGENS) $(KEYMAPS)
> >  
> >  EXTRA_DIST =					\
> >  	decode-glz-tmpl.c			\
> > +	$(KEYMAPS) 				\
> 
> You've got an extra white-space after the ) (rather than just tabs).
> Same on the 2 next lines.
Fixed locally

Thanks,
Pavel

> 
> >  	$(KEYMAP_CSV) 				\
> >  	$(KEYMAP_GEN) 				\
> >  	map-file				\
> 
> Christophe