[Spice-devel] [spice-server v2 2/6] net: Introduce red_socket_set_non_blocking() helper

[Christophe Fergeau]

On Fri, Mar 10, 2017 at 08:41:50AM -0500, Frediano Ziglio wrote:
> > 
> > On Fri, Mar 10, 2017 at 09:59:38AM +0100, Christophe Fergeau wrote:
> > > This allows to move some low-level code out of reds.c
> > 
> > Forgot that this patch (or one of the patches in this series) needs a
> > minor spice-common patch too to avoid build failures.
> > 
> > diff --git a/common/log.h b/common/log.h
> > index 0e03f59..11261ca 100644
> > --- a/common/log.h
> > +++ b/common/log.h
> > @@ -18,6 +18,8 @@
> >  #ifndef H_SPICE_LOG
> >  #define H_SPICE_LOG
> > 
> > +#include <stdio.h>
> > +
> >  #include <glib.h>
> > 
> >  #include <spice/macros.h>
> > 
> > Christophe
> > 
> 
> This patch looks weird.
> Why is this necessary?
> Maybe the problem is that this file is not self independent?
> 

Yes, the use of fprintf/stderr for spice_printerr means stdio.h is
required. Usually we get it indirectly, but net-utils.h does not include
many headers.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170316/d927fc62/attachment.sig>