[Spice-devel] [spice-server v2 1/6] reds-stream: Introduce reds_stream_set_no_delay() helper

[Christophe Fergeau]

On Fri, Mar 10, 2017 at 08:36:46AM -0500, Frediano Ziglio wrote:
> > diff --git a/server/red-channel-client.c b/server/red-channel-client.c
> > index a86833d..9fca8c1 100644
> > --- a/server/red-channel-client.c
> > +++ b/server/red-channel-client.c
> > @@ -571,13 +571,7 @@ static void
> > red_channel_client_send_ping(RedChannelClient *rcc)
> >          }  else {
> >              rcc->priv->latency_monitor.tcp_nodelay = delay_val;
> >              if (!delay_val) {
> > -                delay_val = 1;
> > -                if (setsockopt(rcc->priv->stream->socket, IPPROTO_TCP,
> > TCP_NODELAY, &delay_val,
> > -                               sizeof(delay_val)) == -1) {
> > -                   if (errno != ENOTSUP) {
> > -                        spice_warning("setsockopt failed, %s",
> > strerror(errno));
> > -                    }
> > -                }
> > +                reds_stream_set_no_delay(rcc->priv->stream, TRUE);
> 
> Why not true ?
> (same below)

Rest of the file still uses TRUE/FALSE, I think I prefer to keep things
consistent for now.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170316/074206b8/attachment.sig>