[Spice-devel] [spice-server v2 6/6] build-sys: Add configure check for TCP_KEEPIDLE

Christophe Fergeau cfergeau at redhat.com
Thu Mar 16 12:39:23 UTC 2017


On Fri, Mar 10, 2017 at 08:57:46AM -0500, Frediano Ziglio wrote:
> 
> > 
> > On Fri, Mar 10, 2017 at 09:59:42AM +0100, Christophe Fergeau wrote:
> > > This is only available in newer FreeBSD releases (9.1 and later), and
> > > will cause build errors or older versions
> > > 
> > > This fixes https://bugs.freedesktop.org/show_bug.cgi?id=99213
> 
> Do we support *BSD ?

Depends what you mean by support :) I do not mind fixing the build in
this case, especially as I needed the configure.ac magic for other work.

Christophe

> 
> > > ---
> > >  configure.ac       | 10 ++++++++++
> > >  server/net-utils.c |  2 ++
> > >  2 files changed, 12 insertions(+)
> > > 
> > > diff --git a/configure.ac b/configure.ac
> > > index f04585f..70ce13b 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -50,6 +50,16 @@ AC_C_BIGENDIAN
> > >  PKG_PROG_PKG_CONFIG
> > >  
> > >  AC_CHECK_HEADERS([sys/time.h execinfo.h linux/sockios.h])
> > > +AC_CHECK_DECL([TCP_KEEPIDLE], [have_tcp_keepidle="yes"],,
> > > +              [#include <netinet/tcp.h>])
> > > +AS_IF([test "x$have_tcp_keepidle" = "xyes"],
> > > +      [AC_DEFINE([HAVE_TCP_KEEPIDLE],1,[Define to 1 if <netinet/tcp.h> has
> > > a TCP_KEEPIDLE definition])],
> > > +      [AC_CHECK_DECL([TCP_KEEPALIVE], [have_tcp_keepalive="yes"],,
> > > +                     [#include <netinet/tcp.h>])]
> > > +)
> > > +AS_IF([test "x$have_tcp_keepalive" = "xyes"],
> > > +      [AC_DEFINE([HAVE_TCP_KEEPALIVE],1,[Define to 1 if <netinet/tcp.h>
> > > has a TCP_KEEPALIVE definition])],
> > > +)
> > >  AC_FUNC_ALLOCA
> > 
> > Grmble, and this one is doing too much, the HAVE_TCP_KEEPALIVE check was
> > an experiment for another patch, not something which is required here.
> > 
> > Christophe
> > 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170316/7b0bfbb4/attachment.sig>


More information about the Spice-devel mailing list