[Spice-devel] [spice-server v2 4/6] reds-stream: Introduce reds_stream_get_no_delay() helper

[Christophe Fergeau]

On Fri, Mar 10, 2017 at 08:53:38AM -0500, Frediano Ziglio wrote:
> > diff --git a/server/reds-stream.h b/server/reds-stream.h
> > index 37ba87c..b4fc8b2 100644
> > --- a/server/reds-stream.h
> > +++ b/server/reds-stream.h
> > @@ -73,6 +73,7 @@ int reds_stream_enable_ssl(RedsStream *stream, SSL_CTX
> > *ctx);
> >  int reds_stream_get_family(const RedsStream *stream);
> >  bool reds_stream_is_plain_unix(const RedsStream *stream);
> >  bool reds_stream_set_no_delay(RedsStream *stream, bool no_delay);
> > +int reds_stream_get_no_delay(RedsStream *stream);
> >  int reds_stream_send_msgfd(RedsStream *stream, int fd);
> >  
> >  typedef enum {
> 
> Maybe I'm cheating but I would return just a bool and if is not
> a socket I would return true.

Yes, I'd prefer to return a proper error to the caller, and let it
decide what to do if things went wrong.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170316/3ffcd642/attachment.sig>