[Spice-devel] [PATCH spice] Do not ignore errors

[Christophe Fergeau]

On Fri, Mar 17, 2017 at 02:06:11PM +0100, Pavel Grunt wrote:
> ---
> I am not an expert on auto* and make, but `-k` should be enough to keep going over
> all the tests.
> 
> Example of ci output thanks to this change:
>  https://gitlab.com/xerus/spice/builds/12448734
> 
> https://gitlab.com/xerus/spice/commits/valgrind 
> ---
>  m4/ax_valgrind_check.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/m4/ax_valgrind_check.m4 b/m4/ax_valgrind_check.m4
> index 3761fd5e..ab929623 100644
> --- a/m4/ax_valgrind_check.m4
> +++ b/m4/ax_valgrind_check.m4
> @@ -187,7 +187,7 @@ endif
>  # Use recursive makes in order to ignore errors during check
>  check-valgrind:
>  ifeq ($(VALGRIND_ENABLED),yes)
> -	-$(A''M_V_at)$(foreach tool,$(valgrind_enabled_tools), \
> +	$(A''M_V_at)$(foreach tool,$(valgrind_enabled_tools), \
>  		$(MAKE) $(AM_MAKEFLAGS) -k check-valgrind-$(tool); \

This does not seem to work if you enable several tools, and eg
check-valgrind-memcheck fails while check-valgrind-helgrind succeeds,
it returned 0 in that case in my testing.

Frediano suggested switching to

diff --git a/m4/ax_valgrind_check.m4 b/m4/ax_valgrind_check.m4
index 3761fd5..0ef29f9 100644
--- a/m4/ax_valgrind_check.m4
+++ b/m4/ax_valgrind_check.m4
@@ -184,15 +184,7 @@ else
 valgrind_lt =
 endif

-# Use recursive makes in order to ignore errors during check
-check-valgrind:
-ifeq ($(VALGRIND_ENABLED),yes)
-       -$(A''M_V_at)$(foreach tool,$(valgrind_enabled_tools), \
-               $(MAKE) $(AM_MAKEFLAGS) -k check-valgrind-$(tool); \
-       )
-else
-       @echo "Need to reconfigure with --enable-valgrind"
-endif
+check-valgrind: $(foreach tool,$(valgrind_enabled_tools), check-valgrind-$(tool))

and using make -k if one wants to see the result of all enabled tests while
ignoring the failures.

However, it would be best to get this upstream first ( https://www.gnu.org/software/autoconf-archive/How-to-contribute.html#How-to-contribute )
In the mean time, this workaround should work: (with a link to the upstream bug)

diff --git a/server/Makefile.am b/server/Makefile.am
index e949aee..3187002 100644
--- a/server/Makefile.am
+++ b/server/Makefile.am
@@ -2,7 +2,7 @@ NULL =
 SUBDIRS = . tests

 check-valgrind:
-       $(MAKE) -C tests check-valgrind
+       $(MAKE) -C tests check-valgrind-memcheck

 AM_CPPFLAGS =                                  \
        -DSPICE_SERVER_INTERNAL                 \


Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170321/4e37261f/attachment.sig>