[Spice-devel] [PATCH spice-server v3 1/2] build-sys: Add option to enable additional checks

[Pavel Grunt]

Hi,

On Wed, 2017-03-22 at 16:20 +0000, Frediano Ziglio wrote:
> This to enable extra test.
> This option is used also in different projects.
I would remove the last sentence
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  configure.ac | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 9fd455b..42ce1c1 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -237,6 +237,11 @@ AC_ARG_ENABLE([statistics],
>  AS_IF([test "$enable_statistics" = "yes"],
>        [AC_DEFINE([RED_STATISTICS], [1], [Enable SPICE
> statistics])])
>  
> +AC_ARG_ENABLE([extra-checks],
> +               AS_HELP_STRING([--enable-extra-
> checks=@<:@yes/no@:>@],
> +                              [Enable extra runtime checks 

in our case they are not runtime checks, so I'd go for "Enable
expensive checks" or "Enable extra trsts". We can adjust the comment
in the future if the functionality changes.

Besides that it looks good to me,
Pavel


> @<:@default=no@:>@]))
> +AM_CONDITIONAL(ENABLE_EXTRA_CHECKS, test "$enable_extra_checks" =
> "yes")
> +
>  dnl
> ====================================================================
> =======
>  dnl check compiler flags
>