[Spice-devel] [PATCH spice-gtk 1/4] build-sys: update spice-common submodule

[Christophe Fergeau]

On Tue, Mar 28, 2017 at 05:10:06PM +0200, Pavel Grunt wrote:
> On Tue, 2017-03-28 at 17:03 +0200, Christophe Fergeau wrote:
> > On Tue, Mar 28, 2017 at 04:45:05PM +0200, Pavel Grunt wrote:
> > > On Tue, 2017-03-28 at 16:32 +0200, Victor Toso wrote:
> > > > On Tue, Mar 28, 2017 at 04:25:05PM +0200, Pavel Grunt wrote:
> > > > > On Tue, 2017-03-28 at 15:51 +0200, marcandre.lureau at redhat.com
> > > > > wrote:
> > > > > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > > > 
> > > > > > Fixing make dist.
> > > > > 
> > > > > What issue does it have ?
> > > > 
> > > > https://paste.fedoraproject.org/paste/-IbDp8v41eONDFhfpne7Bl5M1U
> > > > NdIG
> > > > YhyRLivL9gydE=
> > > > 
> > > > Patch fixes it
> > > > Acked-by: Victor Toso <victortoso at redhat.com>
> > > 
> > > ok, thanks... I don't have any errors... same for the machine
> > > doing
> > > the nightly builds (it is doing `make && make dist`)
> > 
> > Why not "make distcheck" ?
> 
> without make it fails:
> libtool:   error: cannot find the library '../../src/libspice-client-
> glib-2.0.la' or unhandled argument '../../src/libspice-client-glib-
> 2.0.la'
> Linking of scanner failed: 
> make[3]: *** [Makefile:764: scan-build.stamp] Error 1
> make[3]: Leaving directory '/home/pgrunt/src/spice-gtk/doc/reference'
> make[2]: *** [Makefile:576: distdir] Error 1
> make[2]: Leaving directory '/home/pgrunt/src/spice-gtk/doc'
> make[1]: *** [Makefile:767: distdir] Error 1
> make[1]: Leaving directory '/home/pgrunt/src/spice-gtk'
> make: *** [Makefile:865: dist] Error 2
> 
> if you are talking about make && make distcheck then I am using copr
> to inform me about build failures

Yeah, could be make && make distcheck (or an added dep on the .la files
where appropriate in gtk-doc generation).
The build done by 'make distcheck' is quite different from your
traditional 'build from tarball' as it tests builddir != srcdir, and
read-only srcdir

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170328/1e048e3b/attachment.sig>